Tag command injection fix #24861
Merged
Tag command injection fix #24861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2025 16:21
…tency and just incase the manual input tags present another attack vector
github-actions
bot
added
area: build
…to bdiaz/tagCommandInjectFix
There was a problem hiding this comment.
Pull Request Overview
This PR replaces unsafe git checkout commands with the pinned actions/checkout action and adds secure parameters to mitigate tag command injection.
- Swaps out raw
git checkoutforactions/checkout@<sha>with explicitref. - Adds
fetch-depth: 0andpersist-credentials: falseto ensure full history and no credential leakage.
Comments suppressed due to low confidence (1)
.github/workflows/push-tag-create-release.yml:89
- [nitpick] The checkout action is duplicated for push and workflow_dispatch jobs; consider consolidating into a single step by parameterizing the ref to reduce duplication and improve maintainability.
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
Abe27342
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use checkout action instead of command line for checking out a tag in GitHub Actions.
I validated the bug fix by putting a code injection in release tag and then pushing the tag to main on my fork. The result of this was that the injection was completely omitted from the tag name, and the workflow worked as expected:
https://github.com/Toritos01/FluidFramework/actions/runs/15691947672/job/44209020812